This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
[WIP] Use haskell-lsp with VFS race condition fix #1446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanz
commented
Nov 10, 2019
|
|
||
| -- The commands to be executed on the server. | ||
| -- If you set `executeCommandHandler`, you **must** set this. | ||
| , Core.executeCommandCommands = Just commandIds |
There was a problem hiding this comment.
I am not sure if these are set up correctly, please provide input.
There was a problem hiding this comment.
I don't know either is this @bubba who changed it?
There was a problem hiding this comment.
I have a branch for these options, I'll apply it on top of this after this is merged /~https://github.com/bubba/haskell-ide-engine/tree/new-haskell-lsp-options
mpickering
reviewed
Nov 10, 2019
| @@ -275,7 +275,7 @@ readVFS :: (MonadIde m, MonadIO m) => Uri -> m (Maybe T.Text) | |||
| readVFS uri = do | |||
| mvf <- getVirtualFile uri | |||
| case mvf of | |||
| Just (VirtualFile _ txt _) -> return $ Just (Rope.toText txt) | |||
| Just (VirtualFile _ txt) -> return $ Just (Rope.toText txt) | |||
There was a problem hiding this comment.
We should make VirtualFile more abstract and provide an accessor to get the text out (I have this on my dejafu branch).
| (Just (VFS.VirtualFile _ yitext _), Just fp) -> do | ||
| let text' = Rope.toString yitext | ||
| (Just (VFS.VirtualFile _ rope), Just fp) -> do | ||
| let text' = Rope.toString rope |
| @@ -798,7 +799,7 @@ withDocumentContents reqId uri f = do | |||
| (J.responseId reqId) | |||
| J.InvalidRequest | |||
| "Document was not open" | |||
| Just (VFS.VirtualFile _ txt _) -> f (Rope.toText txt) | |||
| Just (VFS.VirtualFile _ txt) -> f (Rope.toText txt) | |||
|
|
||
| -- The commands to be executed on the server. | ||
| -- If you set `executeCommandHandler`, you **must** set this. | ||
| , Core.executeCommandCommands = Just commandIds |
There was a problem hiding this comment.
I don't know either is this @bubba who changed it?
|
Closed in favour of #1457 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use work @mpickering has done to get rid of race conditions in VFS
Do not merge, this is a test branch, to confirm operation prior to publishing new
haskell-lspandlsp-testmodules.